Skip to content

Facebook: update color code #83036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2023
Merged

Facebook: update color code #83036

merged 2 commits into from
Oct 18, 2023

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Oct 16, 2023

Proposed Changes

Facebook's color code was updated a few years ago. Let's update its color here too.

References:

Testing Instructions

  • In the Calypso live link, go to Marketing > Connections
  • Check the color of the Facebook logo

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@jeherve
Facebook: update color code
4d4b6f4 
Facebook's color code was updated a few years ago. Let's update its color here too.

References:

- Automattic/jetpack#13681
@jeherve jeherve added [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Pri] TBD Review and assign an appropriate [Pri] label as soon as possible. [Feature] Social Media Integration Tools for connecting and integrating your site with social media platforms. labels Oct 16, 2023
@jeherve jeherve self-assigned this Oct 16, 2023
@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-84496
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-84496&env=jetpack

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit update/facebook-color-code on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@matticbot
Copy link
Contributor

This PR modifies the release build for happy-blocks

To test your changes on WordPress.com, run install-plugin.sh happy-blocks update/facebook-color-code on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-r7r-p2

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • editing-toolkit
  • happy-blocks
  • odyssey-stats

To test WordPress.com changes, run "install-plugin.sh update/facebook-color-code" on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@jeherve jeherve requested a review from a team October 16, 2023 11:23
@jeherve jeherve mentioned this pull request Oct 16, 2023
Merged
3 tasks
monsieur-z
monsieur-z reviewed Oct 16, 2023
View reviewed changes
Copy link

@monsieur-z monsieur-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at facebook.com, the latest blue seems slightly brighter: #0866FF.

@jeherve
Copy link
Member Author

jeherve commented Oct 17, 2023

Looking at facebook.com, the latest blue seems slightly brighter: #0866FF.

You're right, good catch. I updated it here, and created a PR in the Jetpack repo to match this change:
Automattic/jetpack#33633

@jeherve jeherve added [Pri] Low Address when resources are available. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Pri] TBD Review and assign an appropriate [Pri] label as soon as possible. labels Oct 17, 2023
@jeherve jeherve merged commit 9491815 into trunk Oct 18, 2023
@jeherve jeherve deleted the update/facebook-color-code branch October 18, 2023 07:05
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2023
@jeherve jeherve mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@monsieur-z monsieur-z monsieur-z approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jeherve jeherve

Labels
[Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. [Feature] Social Media Integration Tools for connecting and integrating your site with social media platforms. [Pri] Low Address when resources are available. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeherve @matticbot @monsieur-z