-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paid/Free Confidence check experiment name update #81408
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~11 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~23 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though this is a draft, it LGTM!
@@ -70,7 +70,7 @@ export function useGetWordPressSubdomain( paidDomainName: string ) { | |||
quantity: 1, | |||
include_wordpressdotcom: true, | |||
include_dotblogsubdomain: false, | |||
only_wordpressdotcom: true, | |||
only_wordpressdotcom: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you help me understand why we’d need this change, and also if we could separate it into another PR if it's unrelated?
From the code, if it needs only_wordpressdotcom to be set as false to return the correct dotcom subdomains, it needs to be fixed from the backend rather than the front-end. If that’s the case, the backend fix will then break the front-end if we ship this change. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right I have removed this above change for now so that we can pick this up in a separate PR.
Related to
#Fixes Automattic/growth-foundations#186
Proposed Changes
calypso_onboarding_plans_paid_domain_on_free_plan_confidence_check
Testing Instructions
Pre-merge Checklist