Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paid/Free Confidence check experiment name update #81408

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

ddc22
Copy link
Contributor

@ddc22 ddc22 commented Sep 5, 2023

Related to

#Fixes Automattic/growth-foundations#186

Proposed Changes

  • Change the experiment name to the confidence check experiment calypso_onboarding_plans_paid_domain_on_free_plan_confidence_check
  • Fixes the domain generation where domain were not generating for some domain queries.

Testing Instructions

  • Make sure the assignments works as expected. (Should show the domain purchase allowed modal)
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

@matticbot
Copy link
Contributor

matticbot commented Sep 5, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~11 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
update-design-flow          +17 B  (+0.0%)      +11 B  (+0.0%)
plugins                     +17 B  (+0.0%)      +11 B  (+0.0%)
plans                       +17 B  (+0.0%)      +11 B  (+0.0%)
link-in-bio-tld-flow        +17 B  (+0.0%)      +11 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~23 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected        +17 B  (+0.0%)      +11 B  (+0.0%)
async-load-signup-steps-plans                          +17 B  (+0.0%)      +11 B  (+0.0%)
async-load-signup-steps-domains                        +17 B  (+0.0%)      +12 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@aaronyan aaronyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this is a draft, it LGTM!

@ddc22 ddc22 marked this pull request as ready for review September 5, 2023 22:20
@ddc22 ddc22 requested a review from a team as a code owner September 5, 2023 22:20
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 5, 2023
@@ -70,7 +70,7 @@ export function useGetWordPressSubdomain( paidDomainName: string ) {
quantity: 1,
include_wordpressdotcom: true,
include_dotblogsubdomain: false,
only_wordpressdotcom: true,
only_wordpressdotcom: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help me understand why we’d need this change, and also if we could separate it into another PR if it's unrelated?

From the code, if it needs only_wordpressdotcom to be set as false to return the correct dotcom subdomains, it needs to be fixed from the backend rather than the front-end. If that’s the case, the backend fix will then break the front-end if we ship this change. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right I have removed this above change for now so that we can pick this up in a separate PR.

@ddc22 ddc22 merged commit fd2c07a into trunk Sep 6, 2023
@ddc22 ddc22 deleted the add/paid-free-confidence-check branch September 6, 2023 14:14
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 6, 2023
@southp southp mentioned this pull request Sep 22, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants