Login: Social login button remains disabled if Google SDK fails to init #81152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
zaguiini
approved these changes
Aug 28, 2023
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
p-jackson
force-pushed
the
fix/social-buttons-disabled-if-google-fails-to-setup
branch
from
dbbfbbe to
e1f6d24
Compare
p-jackson
force-pushed
the
fix/social-buttons-disabled-if-google-fails-to-setup
branch
from
e1f6d24 to
aeb13d7
Compare
p-jackson
deleted the
fix/social-buttons-disabled-if-google-fails-to-setup
branch
github-actions
bot
removed
the
[Status] Needs Review
vykes-mac
pushed a commit
that referenced
this pull request
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error raised by p1693237148930679-slack-C04U5A26MJB
Proposed Changes
loadGoogleIdentityServicesAPI()will returns a falsey value when the Google SDK fails to set up the globals correctly.It's unclear why this might happen, but we have seen it happen in production. The code is already designed to handle this case. When
loadGoogleIdentityServicesAPI()returns falsey the social login button stays disabled and the user must use a different login/signup method.Testing Instructions
The usual way of testing—blocking Google scripts—won't work here. In this situation there was no exception thrown by
loadScript()so Google's SDK had no issue loading. In this case I believe we just need to visually confirm that this code change is safe.And also run through the happy login path.