Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack E2E: update expectations for the AI Assistant flow. #81065

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Jetpack E2E: update expectations for the AI Assistant flow. #81065

merged 4 commits into from
Aug 25, 2023

Conversation

worldomonation
Copy link
Contributor

@worldomonation worldomonation commented Aug 25, 2023 •
edited
Loading

Related to #80730.

Proposed Changes

This PR updates the expectations for the AI Assistant block.

Testing Instructions

Ensure the following build configurations are passing:

  • Calypso E2E (desktop)
  • Jetpack E2E Simple (mobile)
  • Jetpack E2E Simple (desktop)
  • Jetpack E2E AT (desktop)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@worldomonation
test/e2e/specs/blocks/blocks__jetpack-writing.ts
04879ad 
- remove 'Canada' from the expected keywords
@worldomonation worldomonation self-assigned this Aug 25, 2023
@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-78737
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-78737&env=jetpack

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@worldomonation worldomonation marked this pull request as ready for review August 25, 2023 08:31
@worldomonation worldomonation requested a review from a team as a code owner August 25, 2023 08:31
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 25, 2023
@worldomonation worldomonation merged commit 46feee0 into trunk Aug 25, 2023
@worldomonation worldomonation deleted the fix/jetpack-ai-assistant-block-expectations branch August 25, 2023 10:08
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 25, 2023
@worldomonation worldomonation mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenroldan karenroldan karenroldan approved these changes

Assignees

@worldomonation worldomonation

Labels
None yet
Projects
KitKat Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@worldomonation @matticbot @karenroldan