Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Partner Portal: add the feature flag and required modules for a page to create a WP.com site #81056

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Aug 25, 2023

Closes https://github.com/Automattic/jetpack-avalon/issues/47

Proposed Changes

This PR adds the feature flags and required modules for a page to create a WP.com site.

Testing Instructions

  • Open the Jetpack Cloud live link
  • Append the URL with /partner-portal/create-site and verify the below screen is shown.
Screenshot 2023-08-25 at 10 25 14 AM
  • Verify that the jetpack/pro-dashboard-wpcom-atomic-hosting feature flag is enabled only in Dev and Horizon environments and not in Staging & Production.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@yashwin yashwin added Jetpack Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Aug 25, 2023
@yashwin yashwin requested a review from a team August 25, 2023 04:56
@yashwin yashwin self-assigned this Aug 25, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 25, 2023
@github-actions
Copy link

github-actions bot commented Aug 25, 2023

@matticbot
Copy link
Contributor

matticbot commented Aug 25, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~51 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
jetpack-cloud-partner-portal       +404 B  (+0.1%)      +51 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@yashwin yashwin requested a review from a team August 25, 2023 05:03
Copy link
Contributor

@jkguidaven jkguidaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new page loads correctly. I have a non-blocking comment, but this is good to go. 👍

config/jetpack-cloud-development.json Outdated Show resolved Hide resolved
@yashwin yashwin merged commit def02e6 into trunk Aug 25, 2023
@yashwin yashwin deleted the add/create-wpcom-site-screen branch August 25, 2023 10:04
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants