Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GF Signup:Fix preloading conditions #81039

Merged
merged 2 commits into from
Aug 25, 2023
Merged

GF Signup:Fix preloading conditions #81039

merged 2 commits into from
Aug 25, 2023

Conversation

ddc22
Copy link
Contributor

@ddc22 ddc22 commented Aug 24, 2023

Related

Proposed Changes

  • Fix preloading conditions for the relevant plans modal experiment.
  • The conditions for preloading the experiment were incorrect. All experiments were pre loaded only when there was a free subdomain. But two of these experiments actually are activated when there is a paid domain. So the code was changed to fix this conditional errors.

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@github-actions
Copy link

github-actions bot commented Aug 24, 2023

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@ddc22 ddc22 self-assigned this Aug 24, 2023
@ddc22 ddc22 marked this pull request as ready for review August 24, 2023 21:08
@ddc22 ddc22 requested a review from a team as a code owner August 24, 2023 21:08
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 24, 2023
@ddc22 ddc22 requested review from aaronyan, a team and jeyip August 24, 2023 21:09
@ddc22 ddc22 changed the title Fix preloading conditions GD Signup:Fix preloading conditions Aug 24, 2023
Copy link
Member

@aaronyan aaronyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've tested both flows and was able to assign myself to treatment and get the modal for a paid domain + free plan.

@southp southp merged commit c526e99 into trunk Aug 25, 2023
@southp southp deleted the fix/pre-loading-conditions branch August 25, 2023 03:09
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 25, 2023
@ddc22 ddc22 changed the title GD Signup:Fix preloading conditions GF Signup:Fix preloading conditions Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants