Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AI Assistant pricing card features #80500

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

nunyvega
Copy link

Related to p1691756324347449-slack-C054LN8RNVA

Proposed Changes

Testing Instructions

  • Checkout this branch locally
  • Start calypso and the Jetpack Cloud environment with yarn start-jetpack-cloud
  • Navigate to http://jetpack.cloud.localhost:3001/pricing
  • Confirm that you see the "AI Assistant" and click on "More about AI"
  • Confirm that the text is updated
  • Check that the copy looks correct and makes sense
  • The list should include "Get feedback about your post"

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@nunyvega nunyvega added [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Aug 11, 2023
@nunyvega nunyvega requested review from augurlu and a team August 11, 2023 13:09
@nunyvega nunyvega self-assigned this Aug 11, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 11, 2023
@matticbot
Copy link
Contributor

matticbot commented Aug 11, 2023

@matticbot
Copy link
Contributor

matticbot commented Aug 11, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~14 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
site-purchases                           +47 B  (+0.0%)      +14 B  (+0.0%)
settings-jetpack                         +47 B  (+0.0%)      +14 B  (+0.0%)
scan                                     +47 B  (+0.0%)      +14 B  (+0.0%)
purchases                                +47 B  (+0.0%)      +14 B  (+0.0%)
purchase-product                         +47 B  (+0.0%)      +14 B  (+0.0%)
plans                                    +47 B  (+0.0%)      +14 B  (+0.0%)
jetpack-search                           +47 B  (+0.0%)      +14 B  (+0.0%)
jetpack-connect                          +47 B  (+0.0%)      +14 B  (+0.0%)
jetpack-cloud-settings                   +47 B  (+0.0%)      +14 B  (+0.0%)
jetpack-cloud-pricing                    +47 B  (+0.0%)      +14 B  (+0.0%)
jetpack-cloud-plugin-management          +47 B  (+0.0%)      +14 B  (+0.0%)
jetpack-cloud-partner-portal             +47 B  (+0.0%)      +14 B  (+0.0%)
jetpack-cloud-features-comparison        +47 B  (+0.0%)      +14 B  (+0.0%)
jetpack-cloud-agency-dashboard           +47 B  (+0.0%)      +14 B  (+0.0%)
email                                    +47 B  (+0.0%)      +14 B  (+0.0%)
domains                                  +47 B  (+0.0%)      +14 B  (+0.0%)
checkout                                 +47 B  (+0.0%)      +14 B  (+0.0%)
backup                                   +47 B  (+0.0%)      +14 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~14 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal             +47 B  (+0.0%)      +14 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal        +47 B  (+0.0%)      +14 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@a8ci18n
Copy link

a8ci18n commented Aug 11, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8704491

Hi @nunyvega, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Get feedback about your post
  • Text, table, list, and form generation

Thank you in advance!

@nunyvega nunyvega force-pushed the update/ai-assistant-features-list branch from 42ef889 to 1f6a5ee Compare August 11, 2023 13:19
Co-authored-by: Douglas Henri <dhasilva@users.noreply.github.com>
Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a8ci18n
Copy link

a8ci18n commented Aug 18, 2023

Translation for this Pull Request has now been finished.

@lhkowalski
Copy link
Contributor

This one needs a rebase a new test to make sure it's compatible with the last changes made on the feature list.

@lhkowalski lhkowalski added [Status] Needs Rebase and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 10, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2024
@nunyvega nunyvega removed their assignment Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) [Status] Needs Rebase [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants