-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Stats Commercial "Annual" plan the default billing term. #80341
Make Stats Commercial "Annual" plan the default billing term. #80341
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~28 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~35 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~98 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested under NZD and it works well. The changes look reasonable as well. Thanks for working on this 👍 👍
This PR makes the Stats Commercial yearly/annual billing term the default plan when selected to purchase (as opposed to the monthly billing term product).
Proposed Changes
Testing Instructions
If code-D118168 is not merged yet, you will first need to apply patch code-D118168 to your sandbox, and sandbox
public-api.wordpress.com
, anddefine( 'USE_STORE_SANDBOX' );
in0-sandbox.php
file.Checkout this PR and run
yarn start
.Go to: http://calypso.localhost:3000/stats/purchase/:SITE (where
:SITE
is the site slug of a self-hosted Jetpack site connected to your account)Select "Commercial site" and verify the Stats Commercial "yearly" billing product is shown at $8.33/mo USD. (See screenshot).
Select the "Get Jetpack Stats" button and verify you are taken to checkout with the "yearly" Stats Commercial product in the cart.
Go back to the http://calypso.localhost:3000/stats/purchase/:SITE page and select "Personal site" this time. Verify the Personal site slider works the same as it always has prior to this PR.
Bonus:
Stats Commercial "Yearly/annual" prices are as follows:
.
Pre-merge Checklist