Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain Transfer - Remove pricing field value when disabled #79979

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

agrullon95
Copy link
Contributor

@agrullon95 agrullon95 commented Jul 28, 2023

Related to https://github.com/Automattic/dotcom-forge/issues/3268

Proposed Changes

  • Remove the "$0" price value under the "Price" column when the field is disabled

Testing Instructions

  • Checkout this PR and run it
  • Navigate to /setup/domain-transfer/domains
  • Verify that the price is no longer displaying when the input fields are empty.
  • Add a valid domain/auth code pair and verify the price is displaying correctly.
  • Add a domain + random auth code pair and verify the price is displaying correctly.
  • Only add a domain and verify the price is not displaying.
  • Only add an auth code and verify the price is not displaying.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@agrullon95 agrullon95 added the [Feature Group] Emails & Domains Features related to email integrations and domain management. label Jul 28, 2023
@agrullon95 agrullon95 requested review from a team July 28, 2023 16:33
@agrullon95 agrullon95 self-assigned this Jul 28, 2023
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 28, 2023
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great 👍

@agrullon95 agrullon95 merged commit 39b8ce9 into trunk Jul 28, 2023
@agrullon95 agrullon95 deleted the remove/domains-transfer-price-field-when-disabled branch July 28, 2023 21:37
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants