-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces IAP message to include WooCommerce #79930
base: trunk
Are you sure you want to change the base?
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~9 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~9 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
cabd86d
to
81c8403
Compare
Editorial review: I might say |
Hi @hannahtinkler can we have the "needs copy review" label removed from this PR? It pops up in Slack each day as needing attention. Thanks in advance! |
Thanks @provenself, updated! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! You may want to do a String Freeze and wait on merging this until the translations are complete, or you could use i18n.hasTranslation
to provide a fallback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the same suggestion from Payton, apart from that LGTM
Replaces the message 'Your current plan is an in-app purchase. You can upgrade to a different plan from within the WordPress app.' with 'Your current plan is an in-app purchase. You can upgrade to a different plan from within the WordPress or WooCommerce apps.' on the 'Plans' section of a given site in Calypso. Ideally we could specify either or based on the plan, but there doesn't seem to be a flag for underlying product type (WPCOM/Woo) in the data I have access to.
Copy review:
Fixes #79924
Proposed Changes
Testing Instructions
Pre-merge Checklist