Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces IAP message to include WooCommerce #79930

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

hannahtinkler
Copy link
Contributor

@hannahtinkler hannahtinkler commented Jul 27, 2023

Replaces the message 'Your current plan is an in-app purchase. You can upgrade to a different plan from within the WordPress app.' with 'Your current plan is an in-app purchase. You can upgrade to a different plan from within the WordPress or WooCommerce apps.' on the 'Plans' section of a given site in Calypso. Ideally we could specify either or based on the plan, but there doesn't seem to be a flag for underlying product type (WPCOM/Woo) in the data I have access to.

Copy review:

  • Your current plan is an in-app purchase. You can upgrade to a different plan from within the WordPress or WooCommerce apps.

Fixes #79924

Proposed Changes

  • Replaces the message 'Your current plan is an in-app purchase. You can upgrade to a different plan from within the WordPress app.' with 'Your current plan is an in-app purchase. You can upgrade to a different plan from within the WordPress or WooCommerce apps.' on the 'Plans' section of a given site in Calypso.

Testing Instructions

  • Have a subscription on your account that was paid for using in-app-purchases (payment method is 'iap_ios', or ping me and I can add one to your account).
  • View the 'Plans' area of Calypso for the site the subscription belongs to (e.g. /plans/)
  • Assert that the in-app purchase warning matches the text above

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@hannahtinkler hannahtinkler added [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Status] Needs Copy Review Add this when you'd like to get a review / feedback from the Editorial team on your PR labels Jul 27, 2023
@hannahtinkler hannahtinkler requested a review from a team as a code owner July 27, 2023 15:16
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 27, 2023
@github-actions
Copy link

github-actions bot commented Jul 27, 2023

@matticbot
Copy link
Contributor

matticbot commented Jul 27, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~9 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
update-design-flow          +23 B  (+0.0%)       +9 B  (+0.0%)
plugins                     +23 B  (+0.0%)       +9 B  (+0.0%)
plans                       +23 B  (+0.0%)       +9 B  (+0.0%)
link-in-bio-tld-flow        +23 B  (+0.0%)       +9 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~9 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected        +23 B  (+0.0%)       +9 B  (+0.0%)
async-load-signup-steps-plans                          +23 B  (+0.0%)       +9 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@hannahtinkler hannahtinkler added [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging and removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Jul 27, 2023
@hannahtinkler hannahtinkler force-pushed the fix/wording-to-include-other-apps branch from cabd86d to 81c8403 Compare July 27, 2023 15:25
@provenself
Copy link

provenself commented Jul 27, 2023

Editorial review: I might say from within the WordPress or WooCommerce mobile apps, but looks good! 👍 (Confirmed with the Woo marketing folks that the Woo app name hasn't changed yet)

@kristastevens
Copy link

Hi @hannahtinkler can we have the "needs copy review" label removed from this PR? It pops up in Slack each day as needing attention. Thanks in advance!

@hannahtinkler hannahtinkler removed [Status] Needs Copy Review Add this when you'd like to get a review / feedback from the Editorial team on your PR [Status] Editorial Input Requested labels Sep 13, 2023
@hannahtinkler
Copy link
Contributor Author

hannahtinkler commented Sep 13, 2023

Editorial review: I might say from within the WordPress or WooCommerce mobile apps, but looks good! 👍 (Confirmed with the Woo marketing folks that the Woo app name hasn't changed yet)

Thanks @provenself, updated! 🙂

Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You may want to do a String Freeze and wait on merging this until the translations are complete, or you could use i18n.hasTranslation to provide a fallback.

@hannahtinkler hannahtinkler added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Sep 13, 2023
Copy link
Contributor

@spraveenitpro spraveenitpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the same suggestion from Payton, apart from that LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update In-app Purchase messaging to include WooCommerce
6 participants