Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy blocks: Remove temporary happy blocks code #79916

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

renancarvalho
Copy link
Contributor

@renancarvalho renancarvalho commented Jul 27, 2023

Proposed Changes

To be able to deploy this PR without any breakage for the users, we had to add temporary code to keep it working fine, this PR removes this temporary code.

Testing Instructions

  • Pull this branch
  • Navigate to apps/happy-blocks and run yarn dev --sync
  • Go to wpsupport3 repo and run it normally.
  • Inspect element and you should see only one div element with these classes happy-blocks-mini-search happy-blocks-header is-support element.

Before:

image

After:

image

@renancarvalho renancarvalho requested a review from a team July 27, 2023 10:17
@renancarvalho renancarvalho self-assigned this Jul 27, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 27, 2023
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleaning up, it works fine 👍

@renancarvalho renancarvalho merged commit 0c27453 into trunk Jul 27, 2023
@renancarvalho renancarvalho deleted the remove_temporary_happyblocks_change branch July 27, 2023 11:57
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants