Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler CTA: Fix selecting the CTA doesn't go to the editor on mobile #79591

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Assembler CTA: Fix selecting the CTA doesn't go to the editor on mobile #79591

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79f3ecc
Design Picker: Fix selecting Assembler CTA doesn't go to the editor o…
arthur791004 Jul 19, 2023
959c8c9
Fix types
arthur791004 Jul 19, 2023
24ae7a9
Fix variable name
arthur791004 Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix variable name
  • Loading branch information
@arthur791004
arthur791004 committed Jul 19, 2023
commit 24ae7a915415ae3b30ebdf49e9b70287b3fb7b64
6 changes: 3 additions & 3 deletions ...tepper/declarative-flow/internals/steps-repository/design-setup/unified-design-picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,8 +446,8 @@ const UnifiedDesignPickerStep: Step = ( { navigation, flow, stepName } ) => {
}
}

function designYourOwn( design: Design, shouldGoToAssemblerStep: boolean ) {
if ( shouldGoToAssemblerStep ) {
function designYourOwn( design: Design, shouldGoToAssembler: boolean ) {
if ( shouldGoToAssembler ) {
const _selectedDesign = {
...design,
design_type: 'assembler',
Expand All @@ -464,7 +464,7 @@ const UnifiedDesignPickerStep: Step = ( { navigation, flow, stepName } ) => {
handleSubmit( {
selectedDesign: _selectedDesign,
selectedSiteCategory: categorization.selection,
shouldGoToAssemblerStep,
shouldGoToAssembler,
} );
} else {
pickDesign( design );
Expand Down