Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Allow bulk domain transfer of domains that are already connected to a WPCOM site #78917

Conversation

leonardost
Copy link
Contributor

@leonardost leonardost commented Jul 3, 2023

Proposed Changes

This PR updates the bulk domain transfer flow to allow transferring domains that are already connected to a WPCOM site.

Transferring already connected domains wasn't possible in that flow because only the transferrable availability status was being considered - that's correct, but we want to make it easier to transfer domains to us.

Screenshots

  • Before

Annotation on 2023-07-03 at 16-16-39

  • After

Annotation on 2023-07-03 at 16-15-19

Testing Instructions

  • Open the live Calypso link or build this branch locally
  • Connect an external domain you own to a WPCOM site
  • Unlock that domain and get its auth code
  • Go to /setup/bulk-domain-transfer/domains
  • Input that domain and its auth code in the form
  • Ensure it's validated correctly and you are able to proceed

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@leonardost leonardost self-assigned this Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@leonardost leonardost added the [Feature Group] Emails & Domains Features related to email integrations and domain management. label Jul 3, 2023
Copy link
Contributor

@hambai hambai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll approve that temporary. In the mean time I'll work on a proper fix where we expose id a domain is transferrable in a separate property

@hambai hambai merged commit 1ffd728 into trunk Jul 4, 2023
@hambai hambai deleted the update/allow-bulk-transferring-domains-that-are-mapped-to-other-sites branch July 4, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants