-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: Reset category selection when searching #78916
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~22 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
e7943a1
to
39c2968
Compare
4d4d57e
to
49b561b
Compare
49b561b
to
0aa8769
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but with a semi-strong suggestion to revise the E2E changes to use a safer method. If you feel strongly that it's not necessary, it's fine to merge and deploy - but please do keep an eye on TeamCity failure statistics for the step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for noticing this behavior, its not expected and it should be fixed here 2345522 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the previous comment so promptly! 🙌
While testing again, I found a new scenario I would like to discuss with you. When searching and selecting a category after the search, the breadcrumb remains with the Search Results
value that can be clicked. When clicking it, it performs the search again but does not include the searched term in the text box.
What do you think about that scenario?
CleanShot.2023-07-05.at.15.41.30.mp4
1ad25c0
to
2e8db5c
Compare
My previous comment is existing behavior and it has been reported as a different issue here: |
2e8db5c
to
e1f6113
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding E2E tests 💯
I have tested it, and it works as advertised. LGTM! 🚢
Fixes #66938
Proposed Changes
When searching on the plugins browser input:
Testing Instructions
/plugins
pageX
button on the inputPre-merge Checklist