-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checkout included features list for new Stats products #78868
Conversation
Thanks for working on this @elliottprogrammer 👍 ----1----
The features shown for Free do NOT work as described or I'm missing something (Do I need sandbox public api?): ----2---- TS checking is failing for the PR which broke the type check in the unit tests:
----3---- I'm working on support check for the Stats products. The products checks are pretty straight forward, but I'm not very sure about the feature checks. I noticed the diffs on WPCOM added the Plans as features, for example D113814-code, so I'm checking plans on the features too. I'm wondering if you have any advice please? Thanks in advance. |
This PR modifies the release build for happy-blocks To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-r7r-p2 |
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
88f96d7
to
8187c8e
Compare
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~111 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~177 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~177 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Thanks for reviewing @kangzj!
Ahh yes, thank you! Ok, adding the Stats products to
@kangzj , AFAIK, I don't think the Features in diff D113814-code have anything to do with the feature-checks in Calypso. If I'm not mistaken the Calypso feature-checks are just independent constants that you can add, although I haven't fully confirmed this, so don't quote me on that, but I believe from memory that this is the case. 😉 @kangzj, this should be ready for re-review again, if you don't mind and have time. Much appreciated. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well!
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8144637 Thank you @elliottprogrammer for including a screenshot in the description! This is really helpful for our translators. |
This PR adds the list of "Included features" displayed on the checkout page, for the new Stats products. (See screenshot):
Screenshots:
Stats paid products (Commercial and PWYW):
** Stats Free product ($0): **
Stats "Included features" items discussion: p1HpG7-ngN-p2#comment-64474
Asana task: 1201210512993648-as-1204939720795290/f
Proposed Changes
calypso-products
package.Testing Instructions
git fetch && git checkout add/checkout-stats-included-features && yarn start
)Pre-merge Checklist