Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk Domain Transfer Flow - Flow redesign #78822

Merged
merged 11 commits into from
Jul 3, 2023
Merged

Bulk Domain Transfer Flow - Flow redesign #78822

merged 11 commits into from
Jul 3, 2023

Conversation

agrullon95
Copy link
Contributor

@agrullon95 agrullon95 commented Jun 30, 2023 •
edited
Loading

This PR addresses styling and functionality of the new Bulk domain flow

Check the designs: cv3VCaN0E2Iw5OTBJQjrad-fi-56%3A15252

CleanShot 2023-07-03 at 09 50 00@2x CleanShot 2023-07-03 at 09 50 30@2x

Testing Instructions

  1. Live link and visit /setup/bulk-domain-transfer/intro
  2. Check the page

@github-actions
Copy link

github-actions bot commented Jun 30, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-72291
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-72291&env=jetpack

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit update/bulk-domain-transfer-design-improvements-v1 on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@matticbot
Copy link
Contributor

matticbot commented Jun 30, 2023 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~4 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +47 B  (+0.0%)       +4 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~40 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
pattern-assembler-step       +307 B  (+0.0%)       +1 B  (+0.0%)
import-flow                  +307 B  (+0.0%)       +1 B  (+0.0%)
bulk-domain-transfer          +66 B  (+2.6%)      +27 B  (+2.5%)
signup                        +47 B  (+0.0%)      +12 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1 bytes added 📈 [gzipped])

name                                                                         parsed_size           gzip_size
async-load-automattic-global-styles-src-components-global-styles-variations       +307 B  (+0.0%)       +1 B  (+0.0%)
async-load-automattic-design-preview                                              +307 B  (+0.0%)       +1 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

agrullon95 and others added 10 commits July 3, 2023 11:23
@agrullon95 @escapemanuele
initial changes for bulk domain transfer redesign
f77472c
@heavyweight @escapemanuele
BulkDomainTransfer: conditionally show delete
7782a72
@heavyweight @escapemanuele
BulkDomainTransfer: display number of domains to be added
f5cb473
@heavyweight @escapemanuele
BulkDomainTransfer: fix styles
8b54bb6
@escapemanuele
Progress bar is back (#78835)
8cf4879
@escapemanuele
Bulk Domain Flow: Intro step (#78837)
dec34ae 
* Unlock icon

* Learn more and some styling

* Font family

* Padding and button width

* Localize url

* Intentscreen without absolute positioning

* Padding mobile for intents

* Fix svg and accurate margin

* Fix select item width

* Padding in flow

* Overwrite css

* Missing cleanup
@renancarvalho @escapemanuele
Bulk Domain Flow: Improvements on styling and layout (#78847)
d3915ed 
Co-authored-by: Omar Alshaker <omar@omaralshaker.com>
Co-authored-by: Paulo Trentin <paulo@paulotrentin.com.br>
Co-authored-by: Gabriel Demichelis <gabrieldemichelis@gmail.com>
Co-authored-by: Philip Jackson <p-jackson@live.com>
Co-authored-by: Paulo Cruz <paulo.cruz@automattic.com>
Co-authored-by: Chi-Hsuan Huang <chihsuan.tw@gmail.com>
Co-authored-by: Luis Felipe Zaguini <26530524+zaguiini@users.noreply.github.com>
Co-authored-by: Payton Swick <payton@foolord.com>
Co-authored-by: Kosta <heavyweight@users.noreply.github.com>
Co-authored-by: Erick Danzer <edanzer@gmail.com>
Co-authored-by: Nicholas Sakaimbo <nsakaimbo@users.noreply.github.com>
Co-authored-by: Paulo Marcos Trentin <paulo@paulotrentin.com.br>
Co-authored-by: Sergey Mitroshin <sergeymitr@gmail.com>
Co-authored-by: Candy Tsai <candy02058912@gmail.com>
Co-authored-by: Daniel Bachhuber <daniel.bachhuber@automattic.com>
Co-authored-by: Wojtek Naruniec <wojtek@naruniec.me>
Co-authored-by: Aneesh Devasthale <aneeshd16@users.noreply.github.com>
Co-authored-by: Miguel San Segundo <1881481+miksansegundo@users.noreply.github.com>
Co-authored-by: Griffith Chen <griffith.chen@automattic.com>
Co-authored-by: Paul Bunkham <paul@dobit.co.uk>
Co-authored-by: Bogomil Stoynov <bogomil.stoynov@automattic.com>
Co-authored-by: Maciej Grabowski <mashikag@users.noreply.github.com>
Co-authored-by: Louis Laugesen <louis.laugesen@gmail.com>
Co-authored-by: timur987 <115007291+timur987@users.noreply.github.com>
Fix track events for buttons (#78759)
fix sign-up as a different user (#78036)
fixes (#78734)
@agrullon95 @escapemanuele
Update back button location on domain input screen
207affb
@agrullon95 @escapemanuele
Adding styling changes
3c30b1b
@agrullon95 @escapemanuele
Updating styling
c7da5ba
@escapemanuele escapemanuele force-pushed the update/bulk-domain-transfer-design-improvements-v1 branch from b337ad7 to c7da5ba Compare July 3, 2023 09:32
@escapemanuele escapemanuele changed the title [DO NOT MERGE] - initial changes for bulk domain transfer redesign Bulk Domain Transfer Flow - Flow redesign Jul 3, 2023
@escapemanuele escapemanuele requested a review from a team July 3, 2023 10:06
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 3, 2023
@escapemanuele escapemanuele marked this pull request as ready for review July 3, 2023 10:07
escapemanuele
escapemanuele approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this addresses a lot and improves the flow greatly. Let's ship this and work on improvements in following PRs 👍

@renancarvalho
Copy link
Contributor

Looks good to me 👍
Good plan @escapemanuele

@escapemanuele escapemanuele merged commit f77f257 into trunk Jul 3, 2023
@escapemanuele escapemanuele deleted the update/bulk-domain-transfer-design-improvements-v1 branch July 3, 2023 10:26
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 3, 2023
@a8ci18n
Copy link

a8ci18n commented Jul 3, 2023 •
edited
Loading

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8088422

Thank you @agrullon95 for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jul 14, 2023 •
edited
Loading

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8088422

Thank you @agrullon95 for including a screenshot in the description! This is really helpful for our translators.

1 similar comment
@a8ci18n
Copy link

a8ci18n commented Jul 28, 2023 •
edited
Loading

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8088422

Thank you @agrullon95 for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Aug 2, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escapemanuele escapemanuele escapemanuele approved these changes

Assignees

@renancarvalho renancarvalho

@agrullon95 agrullon95

@escapemanuele escapemanuele

Labels
None yet
Projects
Vertex Team Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@agrullon95 @matticbot @renancarvalho @a8ci18n @escapemanuele @heavyweight