Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Domain Transfer: Apply new routing #78806

Merged
merged 6 commits into from
Jul 4, 2023
Merged

Conversation

heavyweight
Copy link
Contributor

@heavyweight heavyweight commented Jun 29, 2023

Rename bulk-domain-transfer to domain-transfer
Making the flow available on setup/domain-transfer/domains instead of setup/bulk-domain-transfer/domains

Proposed Changes

  • Rename bulk-domain-transfer to domain-transfer

Testing Instructions

  1. Live link and visit /setup/domain-transfer
  2. Check that the flow is reachable and working well

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit rename-bulk-domain on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@github-actions
Copy link

github-actions bot commented Jun 29, 2023

@matticbot
Copy link
Contributor

matticbot commented Jun 29, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~17 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-subscriptions          -20 B  (-0.0%)      -11 B  (-0.0%)
entry-main                   -20 B  (-0.0%)      -11 B  (-0.0%)
entry-login                  -20 B  (-0.0%)      -11 B  (-0.0%)
entry-domains-landing        -20 B  (-0.0%)      -11 B  (-0.0%)
entry-browsehappy            -20 B  (-0.0%)      -11 B  (-0.0%)
entry-stepper                +13 B  (+0.0%)      -17 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~18 bytes removed 📉 [gzipped])

name                  parsed_size             gzip_size
bulk-domain-transfer      -2627 B  (deleted)    -1098 B  (deleted)
domain-transfer           +2597 B      (new)    +1094 B      (new)
hosting                     +48 B    (+0.0%)       -1 B    (-0.0%)
sites-dashboard             +43 B    (+0.0%)       -6 B    (-0.0%)
settings                    +43 B    (+0.0%)       -5 B    (-0.0%)
home                        +43 B    (+0.0%)       -5 B    (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~5 bytes removed 📉 [gzipped])

name               parsed_size           gzip_size
async-load-design        +43 B  (+0.0%)       -5 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@escapemanuele escapemanuele changed the title BulkDomainTransfer: apply new routing Bulk Domain Transfer: Apply new routing Jul 3, 2023
@escapemanuele escapemanuele marked this pull request as ready for review July 3, 2023 12:38
@escapemanuele escapemanuele requested a review from a team July 3, 2023 13:48
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 3, 2023
Copy link
Contributor

@agrullon95 agrullon95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested until checkout screen. Flow is still working as intended.

@escapemanuele escapemanuele merged commit e4df0d8 into trunk Jul 4, 2023
@escapemanuele escapemanuele deleted the rename-bulk-domain branch July 4, 2023 09:15
@escapemanuele escapemanuele removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants