Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Fix post card errors #78678

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Reader: Fix post card errors #78678

merged 2 commits into from
Jun 28, 2023

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Jun 27, 2023

Proposed Changes

This PR fixes an error with the reader post card that I found while testing #77046.

I couldn't repro on the reader itself, but since those examples worked at some point, it might indicate a hard-to-repro bug.

Testing Instructions

  • Go to /devdocs/blocks/reader-post-card
  • Verify you're no longer seeing errors thrown and the reader card loads correctly.
  • Go to /devdocs/blocks/reader-combined-card
  • Verify you're no longer seeing errors thrown and the reader card loads correctly.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@tyxla tyxla added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Reader The reader site on Calypso. labels Jun 27, 2023
@tyxla tyxla requested review from a team June 27, 2023 11:59
@tyxla tyxla requested a review from a team as a code owner June 27, 2023 11:59
@tyxla tyxla self-assigned this Jun 27, 2023
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

@matticbot
Copy link
Contributor

matticbot commented Jun 27, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~6 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +12 B  (+0.0%)       +6 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~5 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
reader        +12 B  (+0.0%)       +5 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~8 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-design-blocks                                   +15 B  (+0.0%)       +8 B  (+0.0%)
async-load-calypso-components-web-preview-component        +12 B  (+0.0%)       +5 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@tyxla tyxla mentioned this pull request Jun 27, 2023
25 tasks
Copy link
Contributor

@flootr flootr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified there no errors on this branch 👍🏻

@tyxla tyxla merged commit b55cbc4 into trunk Jun 28, 2023
@tyxla tyxla deleted the fix/reader-post-card-errors branch June 28, 2023 08:26
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants