Add signup link to WooCoreProfiler Jetpack login screen

[ilyasfoo]

Related to #78314

Proposed Changes

• Adds signup link to Jetpack login screen for WooCommerce core profiler
• This does not address any styling change, as that will be addressed when Add forgot password customizations for core profiler flow #78391 is merged

Testing Instructions

• Go to this url
• Click on Sign up
• Observe that you're redirected to sign up page

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-71141

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-71141&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~5 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
entry-login       +127 B  (+0.0%)       +5 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~6 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect       +127 B  (+0.0%)       +6 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~3 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
async-load-design-blocks       +127 B  (+0.0%)       +3 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[moon0326]

LGTM and tested well 👍 🚀

[chihsuan]

Thanks for adding signup link! @ilyasfoo

Observe that you're redirected to sign up page

When I'm logged in, I see the connection screen.

I think it's unlikely that users would click the signup link in this case. However, it seems a bit confusing. Do you think we should address it?

Screen.Recording.2023-06-21.at.07.36.45.mov

[ilyasfoo]

When I'm logged in, I see the connection screen.

I think it's unlikely that users would click the signup link in this case. However, it seems a bit confusing. Do you think we should address it?

@chihsuan You're right, I was able to reproduce it. I think we should address it by immediately redirecting to connect screen instead of showing the login/signup screen. Maybe better as a follow up.

[ilyasfoo]

@chihsuan I've created a follow-up issue #78474

cc @moon0326

[chihsuan]

You're right, I was able to reproduce it. I think we should address it by immediately redirecting to connect screen instead of showing the login/signup screen. Maybe better as a follow up.

Sounds good! LGTM. Thanks for creating the issue. 🙂