Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Details Notices: Remove selectedSite as required as it will be null for multisite visualization #76844

Merged
merged 1 commit into from
May 12, 2023

Conversation

WBerredo
Copy link
Contributor

Proposed Changes

Mark selectedSite as not required as it can be null on multisite visualization.
This should fix the console error on the Plugin Details page for multisite view.

CleanShot 2023-05-11 at 15 10 48@2x

Testing Instructions

  • From trunk branch
  • Go to a plugins page (/plugins/:plugin-slug). Ex: /plugins/woocommerce
  • Check the console, there SHOULD BE an error as stated above
  • From this branch
  • Go to the same page
  • There SHOULD NOT be any errors on the console

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@WBerredo WBerredo requested a review from a team May 11, 2023 18:16
@WBerredo WBerredo self-assigned this May 11, 2023
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 11, 2023
@github-actions
Copy link

github-actions bot commented May 11, 2023

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@noahtallen noahtallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good 👍

By the way, you don't need to get Calypso's approval for these types of PRs! ;)

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@WBerredo WBerredo merged commit 3a2fb70 into trunk May 12, 2023
@WBerredo WBerredo deleted the fix/plugin-details-notices-console-error branch May 12, 2023 13:39
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants