Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pricing page: Update JP Starter and Security product card plan features. #76651

Merged

Conversation

elliottprogrammer
Copy link
Contributor

@elliottprogrammer elliottprogrammer commented May 7, 2023

This PR updates the Jetpack Starter and Jetpack Security plan product cards on the pricing page to the Backup storage size limits and Anti-spam API limits in the copy. (See Before & After screenshots below)

BEFORE AFTER

Asana Task: 1201210512993648-as-1204545118661009/f
Related to Slack discussion: p1683376489774319-slack-C02L8G7V18X

Testing Instructions

  • Spin up this PR in dev environment
    • Run git fetch && git checkout update/starter-security-plan-product-card-features
    • Run yarn start-jetpack-cloud
  • OR use the "Jetpack Cloud live (direct link)" provided below.
  • Navigate to http://jetpack.cloud.localhost:3000/pricing (OR if using the Live link below, add /pricing after the url hostname (ie.- https://my-container.jetpack-cloud.live).
  • Verify that the Backup storage limits and the Anti-spam API call limits have been added to the Jetpack Starter and Jetpack Security product cards plan descriptions. (See BEFORE & AFTER screenshots above).
  • Verify the copy change looks correct ,and makes sense, and the limits are correct for each plan.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@elliottprogrammer elliottprogrammer added [Size] XS Tiny sized issue [Feature] Pricing Feedback related to the pricing structure of WordPress.com's plans and services. Copy task Updating UI copy labels May 7, 2023
@elliottprogrammer elliottprogrammer requested a review from a team as a code owner May 7, 2023 02:28
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 7, 2023
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~18 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +50 B  (+0.0%)      +18 B  (+0.0%)
entry-main           +50 B  (+0.0%)      +18 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Async-loaded Components (~18 bytes added 📈 [gzipped])

name                                           parsed_size           gzip_size
async-load-calypso-blocks-inline-help-popover        +50 B  (+0.0%)      +18 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@elliottprogrammer elliottprogrammer requested review from a team and IanRamosC May 7, 2023 02:32
Copy link
Contributor

@IanRamosC IanRamosC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and tests well! :shipit:

@IanRamosC IanRamosC added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 7, 2023
@IanRamosC IanRamosC merged commit 6c8e677 into trunk May 7, 2023
@IanRamosC IanRamosC deleted the update/starter-security-plan-product-card-features branch May 7, 2023 13:18
@a8ci18n
Copy link

a8ci18n commented May 7, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7973815

Thank you @elliottprogrammer for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented May 11, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Copy task Updating UI copy [Feature] Pricing Feedback related to the pricing structure of WordPress.com's plans and services. [Size] XS Tiny sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants