Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding issue in from site #75523

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Fix encoding issue in from site #75523

merged 1 commit into from
Apr 11, 2023

Conversation

ouikhuan
Copy link
Contributor

Related to #75522

Proposed Changes

  • In this PR, we encoded the from site query string before sending it down to the generatePath function so it won't get confused later

Testing Instructions

  • Create a JN site, connect to your WordPress.com with user approval.
  • Navigate to http://calypso.localhost:3000/setup/import-focused/import?siteSlug=${site_slug}.
  • Fill in the site address and go through the flow.
  • If you link your JN site correctly it should allow you to click on the import everything continue button
  • Open your inspector and make sure there's no error like Uncaught (in promise) BadRequestError: Site url is not valid. when you land on the content chooser screen.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@ouikhuan ouikhuan requested a review from a team April 11, 2023 06:31
@ouikhuan ouikhuan self-assigned this Apr 11, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 11, 2023
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~15 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
site-setup-flow        +30 B  (+0.0%)      +15 B  (+0.0%)
import-flow            +30 B  (+0.0%)      +15 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@zaerl zaerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ouikhuan ouikhuan merged commit cccee83 into trunk Apr 11, 2023
@ouikhuan ouikhuan deleted the fix/from-site-encode branch April 11, 2023 07:06
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 11, 2023
@bogiii
Copy link
Contributor

bogiii commented Apr 11, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants