Hide free plan for domain upsell flow

[agrullon95]

Related to #74416

Testing / Review Estimation

Test: short
Review: short

Proposed Changes

• Hides free plan on the plan selection screen for domain upsell flow

Testing Instructions

• Checkout branch
• Create or use an existing launchpad-enabled site (Write/build/free flow)
• Click the "Choose a domain" task
• Select a random domain and verify the plan selection screen does not display a free plan.
• Go back to the domain selection screen. Click "Use a domain I own" and go through the steps until you reach the plans screen again. Verify the plan selection screen does not display a free plan.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-a47d49f4081be9e2d0cd7e59305ed28e8e6c1aa8

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-a47d49f4081be9e2d0cd7e59305ed28e8e6c1aa8&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~7 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
update-design-flow            +110 B  (+0.0%)      +21 B  (+0.0%)
tailored-ecommerce-flow        -22 B  (-0.0%)      -14 B  (-0.0%)
newsletter-flow                -22 B  (-0.0%)      -14 B  (-0.0%)
link-in-bio-tld-flow           -22 B  (-0.0%)      -14 B  (-0.0%)
link-in-bio-flow               -22 B  (-0.0%)      -14 B  (-0.0%)
copy-site-flow                 -22 B  (-0.0%)      -14 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[edanzer]

Just want to clarify what's happening here. Looks like we're taking out special logic for the DOMAIN_UPSELL_FLOW. I think we can do that here - without affecting other flows - because we're invoking setHideFreePlan( true ); on line 51 in domain-upsell.ts.

So basically, we just update that value in state when working within the domain-upsell flow, and the rest of the logic just works down stream.

Assuming that's right, I wonder whether there would be any unanticipated effects of updating that state value? For example, once we invoke setHideFreePlan( true ); that means as long as that state value persist, we'd never show the free plans. Is it possible that a user would end up back on the domains page via some other route/flow where they SHOULD see the free plan, but not see it because we've updated that state value?

Worth noting I can't think of one, but I just want to be sure we don't introduce unexpected changes to the domains page when not intended.

[agrullon95]

We're moving the "hide free plan" logic into the domain-upsell flow itself, instead of having that logic inside the domains step. It's essentially the same thing, but this change allows us to ensure that the Free plan is always hidden for the domain-upsell flow without modifying other code in the plans or domain step (until we decide we want to show the free plan for specific scenarios within the domain-upsell flow).

Assuming that's right, I wonder whether there would be any unanticipated effects of updating that state value? For example, once we invoke setHideFreePlan( true ); that means as long as that state value persist, we'd never show the free plans. Is it possible that a user would end up back on the domains page via some other route/flow where they SHOULD see the free plan, but not see it because we've updated that state value?

This is definitely possible if the same redux state value is retrieved/read in another plans-related component, but that will happen regardless of these changes. The only reference for getHideFreePlan (to retrieve the "hide free plan" value from redux) in stepper plans/plans-wrapper.tsx. This plans component is only used in Link-in-bio, newsletter, and the domain-upsell flow. The link-in-bio and newsletter will not be affected by these changes since they use the "old" plans component design (vs the new plans grid design we see on the /plans screen when going the domain-upsell flow)

[sharpirate]

This tests well, I'll hold off on approval due to Erick's comment