Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update launchpad free/build/write flow sidebar copies #74426

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Update launchpad free/build/write flow sidebar copies #74426

merged 2 commits into from
Mar 15, 2023

Conversation

agrullon95
Copy link
Contributor

Related to #74417

Proposed Changes

  • Update Launchpad sidebar copies for Free, Write, and Build flows

image

Testing Instructions

  • Checkout this branch (or use calypso.live link)
  • Create or use an existing launchpad enabled site (free, write, or build flow)
  • Verify the sidebar copies match the design. Title = Let's get ready to launch! and Subtitle = Here's what to do next.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@agrullon95 agrullon95 added the [Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. label Mar 14, 2023
@agrullon95 agrullon95 requested review from nuriapenya and a team March 14, 2023 14:35
@agrullon95 agrullon95 self-assigned this Mar 14, 2023
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 14, 2023
@github-actions
Copy link

github-actions bot commented Mar 14, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-60059
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-60059&env=jetpack

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~24 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
write-flow                 +104 B  (+0.0%)      -24 B  (-0.1%)
videopress-flow            +104 B  (+0.0%)      -24 B  (-0.0%)
newsletter-flow            +104 B  (+0.0%)      -24 B  (-0.0%)
link-in-bio-tld-flow       +104 B  (+0.0%)      -24 B  (-0.0%)
link-in-bio-flow           +104 B  (+0.0%)      -24 B  (-0.0%)
free-flow                  +104 B  (+0.0%)      -24 B  (-0.0%)
build-flow                 +104 B  (+0.0%)      -24 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jeyip
Copy link
Contributor

jeyip commented Mar 14, 2023

Rerunning e2e tests

edanzer
edanzer approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@edanzer edanzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests as expected and code change are straightforward. Also ran launchpad unit tests to confirm they still pass.

  • Correct headline/tagline show on Free launchpad
  • Correct headline/tagline show on Write launchpad
  • Correct headline/tagline show on Build launchpad
  • Launchpad unit test pass

@sharpirate
Copy link
Contributor

✅ Looks good on my end as well

@agrullon95 agrullon95 merged commit 53fca88 into trunk Mar 15, 2023
@agrullon95 agrullon95 deleted the update/launchpad-free-write-build-sidebar-copies branch March 15, 2023 14:34
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 15, 2023
@a8ci18n
Copy link

a8ci18n commented Mar 15, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7865889

Thank you @agrullon95 for including a screenshot in the description! This is really helpful for our translators.

@Addison-Stavlo Addison-Stavlo mentioned this pull request Mar 16, 2023
Closed
@a8ci18n
Copy link

a8ci18n commented Mar 27, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edanzer edanzer edanzer approved these changes

@sharpirate sharpirate sharpirate approved these changes

@jeyip jeyip jeyip approved these changes

@nuriapenya nuriapenya Awaiting requested review from nuriapenya

Assignees

@agrullon95 agrullon95

Labels
[Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@agrullon95 @matticbot @jeyip @sharpirate @a8ci18n @edanzer