Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reader manage link to top of P2 and A8c Reader feeds #74348

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

davemart-in
Copy link
Contributor

Description

@andrewspittle highlighted that there was no easy way to manage P2s that you had followed from the P2 reader feed. I thought we had removed the button, but it turns out that there never was a button there. :-)

I went ahead and added one to the top of the P2 feed and to the A8c specific feed. I also updated the back button come once you're on the Manage page so it works with all three screens.

Before

before

After

after

Testing Instructions

@davemart-in davemart-in added [Type] Enhancement [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Reader The reader site on Calypso. [Size] S Small sized issue Subscription Management Issues related to the Subscription Management portal (subscribe.wordpress.com). labels Mar 10, 2023
@davemart-in davemart-in requested a review from a team March 10, 2023 20:12
@davemart-in davemart-in requested a review from a team as a code owner March 10, 2023 20:12
@davemart-in davemart-in self-assigned this Mar 10, 2023
@github-actions
Copy link

github-actions bot commented Mar 10, 2023

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~111 bytes added 📈 [gzipped])

name                                        parsed_size           gzip_size
async-load-calypso-reader-p-2-main               +116 B  (+3.6%)      +41 B  (+3.4%)
async-load-calypso-reader-a-8-c-main             +116 B  (+3.6%)      +38 B  (+3.1%)
async-load-calypso-reader-following-manage        +62 B  (+0.0%)      +32 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso. [Size] S Small sized issue [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Subscription Management Issues related to the Subscription Management portal (subscribe.wordpress.com). [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants