Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update help center launchpad site options #73849

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

agrullon95
Copy link
Contributor

@agrullon95 agrullon95 commented Feb 27, 2023

Related to #72276

Proposed Changes

  • Add launchpad related site options to help center helpCenterData window object.

Testing Instructions

  • Checkout this branch
  • To test on simple site: cd apps/editing-toolkit and run yarn dev --sync
  • To test on atomic site: Download the editing-toolkit.zip and upload to your atomic site (PCYsg-ly5-p2)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@github-actions
Copy link

github-actions bot commented Feb 27, 2023

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit update/launchpad-help-center-site-options on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@matticbot
Copy link
Contributor

matticbot commented Feb 27, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~77 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
async-load-automattic-help-center       +255 B  (+0.0%)      +77 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@agrullon95 agrullon95 self-assigned this Feb 27, 2023
@agrullon95 agrullon95 added the [Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens. label Feb 27, 2023
@agrullon95 agrullon95 merged commit 45a0670 into trunk Feb 27, 2023
@agrullon95 agrullon95 deleted the update/launchpad-help-center-site-options branch February 27, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants