Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove backstopjs from dependencies. #73622

Merged
merged 5 commits into from
Feb 22, 2023
Merged

Conversation

worldomonation
Copy link
Contributor

@worldomonation worldomonation commented Feb 21, 2023

Related to #73601.

Proposed Changes

This PR removes backstopjs, workarounds, scripts and files associated with the visual regression tests.

Context: p1677001849898539/1676996972.514049-slack-C02DQP0FP

Key changes:

  • remove entire directory under test/visual.
  • remove dependency on backstopjs which in turn removes its dependency on puppeteer:5.5.0, which was causing errors on Apple Silicon.
  • remove scripts associated with visual regression.
  • update documents where required.

Testing Instructions

Ensure the following build configurations are passing:

  • Unit Tests
  • Any E2E test
  • Code Style
  • Docker image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@worldomonation worldomonation self-assigned this Feb 21, 2023
@github-actions
Copy link

github-actions bot commented Feb 21, 2023

@worldomonation worldomonation marked this pull request as ready for review February 21, 2023 23:45
@worldomonation worldomonation requested a review from a team as a code owner February 21, 2023 23:45
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 21, 2023
Copy link
Contributor

@karenroldan karenroldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 I've also triggered the pre-release tests and all tests passed.

praise: the updates on the docs are also appreciated! 👍🏻

@worldomonation worldomonation merged commit 16ba7be into trunk Feb 22, 2023
@worldomonation worldomonation deleted the remove/backtopjs branch February 22, 2023 23:58
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 22, 2023
@jsnajdr jsnajdr mentioned this pull request Feb 27, 2023
@jsnajdr
Copy link
Member

jsnajdr commented Feb 27, 2023

Hi @worldomonation 👋 Since this PR was merged to trunk, the "Calculate ICFY stats" GitHub action is not running and not submitting stats to iscalypsofastyet.com. That's because the PR removes the PUPPETEER_SKIP_DOWNLOAD env variable from icfy-stats.yml, but leaves the now-empty env: key, which is probably some kind of YAML syntax error.

Fixing this in #73808.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants