Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Storage addon in addons grid #73416

Open
wants to merge 3 commits into
base: add/config-flags-storage-update
Choose a base branch
from

Conversation

gmovr
Copy link
Contributor

@gmovr gmovr commented Feb 16, 2023

Related to Automattic/martech#1510

Proposed Changes

  • Testing to add a storage add-on to the add-ons route in Calypso.
  • Adding overrides for title and description, so we can optionally define these in Calypso vs pulling them from the API.
  • Need to add actual copy, icon, dropdown toggle probably.

Testing Instructions

  • Go to /add-ons?flags=storage-addon and you should see this addon listed among the other ones.
  • Clicking it will take you to checkout
  • Note, does not currently work with the Premium plan, but other plans (Free, Business, etc.) should allow you to Purchase it.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@gmovr gmovr self-assigned this Feb 16, 2023
@github-actions
Copy link

github-actions bot commented Feb 16, 2023

@gmovr gmovr changed the base branch from trunk to add/config-flags-storage-update February 16, 2023 06:53
@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit try/add-storage-addons-to-grid on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@matticbot
Copy link
Contributor

This PR modifies the release build for happy-blocks

To test your changes on WordPress.com, run install-plugin.sh happy-blocks try/add-storage-addons-to-grid on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-r7r-p2

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~13 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +31 B  (+0.0%)      +14 B  (+0.0%)
entry-main           +31 B  (+0.0%)      +13 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~179 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
add-ons       +399 B  (+0.1%)     +179 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~192 bytes added 📈 [gzipped])

name                                           parsed_size           gzip_size
async-load-signup-steps-add-ons                     +399 B  (+0.4%)     +179 B  (+0.5%)
async-load-calypso-blocks-inline-help-popover        +31 B  (+0.0%)      +13 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@gmovr gmovr force-pushed the add/config-flags-storage-update branch from 86afb51 to d5ca8a0 Compare February 23, 2023 07:36
@gmovr gmovr force-pushed the try/add-storage-addons-to-grid branch from af6b7b5 to 2e42cdc Compare February 23, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants