Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Remove Blaze widget header for the mobile app #73244

Merged
merged 2 commits into from
Feb 11, 2023

Conversation

enejb
Copy link
Member

@enejb enejb commented Feb 10, 2023

Related to pe7hp4-aM-p2

Proposed Changes

  • Remove the Blaze Branding header from the widget for when the widget is displayed in the mobile app.

Testing Instructions

  • Load this PR.
  • Using the Mozilla/5.0 (iPhone; CPU iPhone OS 14_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0.3 Mobile/15E148 wp-android UA header. You can change it in the developer tools preview

Screenshot 2023-02-10 at 6 02 01 AM

Notice that the header is not there any more.

Notice that the header is there when using a regular iPhone or Android browser headers.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@github-actions
Copy link

github-actions bot commented Feb 10, 2023

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@enejb enejb added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 10, 2023
@enejb enejb self-assigned this Feb 10, 2023
@enejb enejb added [Feature] Blaze on WordPress.com Promoting your sites content using Blaze, and the display of Blaze ads on WordPress.com. Jetpack App labels Feb 10, 2023
@enejb enejb requested a review from zwarm February 10, 2023 14:36
Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @enejb . I tested by launching a webview within the Jetpack app. As expected; the header does not show.

@enejb enejb merged commit 69605ec into trunk Feb 11, 2023
@enejb enejb deleted the update/blaze-widget-mobile-app-2 branch February 11, 2023 00:54
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blaze on WordPress.com Promoting your sites content using Blaze, and the display of Blaze ads on WordPress.com. Jetpack App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants