Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2nd JPBU storage product renews original instead of purchasing new. #72395

Merged

Conversation

elliottprogrammer
Copy link
Contributor

@elliottprogrammer elliottprogrammer commented Jan 20, 2023

Proposed Changes

This PR works along with patch D98931-code and fixes issue https://github.com/Automattic/jpop-issues/issues/7976 where attempting to purchase a 2nd duplicate JPBU storage add-on product was renewing the original product instead of purchasing a second storage add-on product.

Fixes: https://github.com/Automattic/jpop-issues/issues/7976

Testing Instructions

  • This PR works along side with WPCOM patch D98931-code.
  • Full testing instructions are located on patch D98931-code .

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #


  • To see the specific tasks where the Asana app for GitHub is being used, see below:
    • 0-as-1203623199319062

@elliottprogrammer elliottprogrammer added Jetpack Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) [Feature] Backups The Jetpack Backup product labels Jan 20, 2023
@elliottprogrammer elliottprogrammer self-assigned this Jan 20, 2023
@github-actions
Copy link

github-actions bot commented Jan 20, 2023

@matticbot
Copy link
Contributor

matticbot commented Jan 20, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~31 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
plans         +44 B  (+0.0%)      +16 B  (+0.0%)
backup        +44 B  (+0.0%)      +15 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@elliottprogrammer elliottprogrammer force-pushed the fix/second-jpbu-storage-purchase-renews-not-purchases branch from e137fa6 to 1f19fa9 Compare January 25, 2023 00:04
@elliottprogrammer elliottprogrammer requested a review from a team January 25, 2023 21:03
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 25, 2023
Copy link
Contributor

@TheSteveK TheSteveK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with backend changes 🚀

@elliottprogrammer elliottprogrammer merged commit fb65606 into trunk Feb 14, 2023
@elliottprogrammer elliottprogrammer deleted the fix/second-jpbu-storage-purchase-renews-not-purchases branch February 14, 2023 18:56
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Backups The Jetpack Backup product Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants