Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Pro Portal: Capitalize "Pro" on prices page #72030

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Jetpack Pro Portal: Capitalize "Pro" on prices page #72030

wants to merge 1 commit into from

Conversation

rcoll
Copy link
Member

@rcoll rcoll commented Jan 12, 2023

Proposed Changes

  • Jetpack Pro is a proper noun, and thus must always be capitalized. This changes a single lowercase p to an uppercase P.

Testing Instructions

  • The description copy at the top of /partner-portal/prices should read "Please note that the Jetpack Pro Dashboard prices will be..." and the "Pro" should be capitalized in this PR.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #

@rcoll rcoll added [Size] S Small sized issue Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) Jetpack Licensing Portal labels Jan 12, 2023
@rcoll rcoll requested review from a team January 12, 2023 20:39
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 12, 2023
@matticbot
Copy link
Contributor

matticbot commented Jan 12, 2023 •
edited
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-53838
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-53838&env=jetpack

@github-actions
Copy link

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-3e291b124f7ae1836631fde9fb8b99e91bad29c4
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-3e291b124f7ae1836631fde9fb8b99e91bad29c4&env=jetpack

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

rcanepa
rcanepa approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@rcanepa rcanepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcanepa rcanepa rcanepa approved these changes

Assignees
No one assigned
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) Jetpack Licensing Portal [Size] S Small sized issue [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcoll @matticbot @rcanepa