-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the pre-sales chat on the Cloud pricing page for the Holidays. #71390
Disable the pre-sales chat on the Cloud pricing page for the Holidays. #71390
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice catch! Though I'll call it out explicitly, because it took me a minute to find: the start time is set to January of next year, rather than December of this year. |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~54 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
so that the chat shutdown occurs at the same time in both Calypso and Jetpack.com.
Thanks @TheSteveK and @mattgawarecki for catching this. 👍 It's strange.. I actually encountered this bug already when I was coding it.. (it's when I was reminded/re-learned that JavaScript months go from 0 to 11). I could swear I fixed both the startTime and endTime, but apparently I did something whereas the startTime didn't get fixed properly. 🤷♂️ Anyway, thanks again, got it all fixed now. Also I fixed the endTime to match the end date on Jetpack.com (Jan 2). |
Wait a minute.. I just realized a problem with this PR.. I need to move the holiday shutdown logic out from this component because I realize this component is used elsewhere also, I believe.. I'm labeling this PR "in progress" for the moment. |
No, I was wrong about this.. ^^ The component is not used elsewhere.. It is a component specifically for the Jetpack product store and located in the product store directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! If the timeframes what we desire, the code looks good.
Dismissing, as I re-reviewed it and Steve is AFK. We need to deliver ASAP
Proposed Changes
This PR disables the Zendesk pre-sales Chat interface on the Jetpack Cloud pricing page automatically between the dates of Dec 23, 2022 midnight UTC thru Jan 3, 2023 midnight UTC.
Related to: p1671473237696439-slack-C04BZQFCWE9
Testing Instructions
Note: The pre-sales chat does not run on weekends (UTC), so if you're testing this PR on a weekend day and the chat is not showing, this is why. You'll need to change your local computer date/time to a non-weekend day.
/pricing
git fetch && git checkout update/disable-presales-chat-for-holidays
yarn start-jetpack-cloud
Pre-merge Checklist