Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pre-sales chat for logged-in users in Production env. #71345

Merged

Conversation

elliottprogrammer
Copy link
Contributor

@elliottprogrammer elliottprogrammer commented Dec 19, 2022

Proposed Changes

This PR enables the Zendesk pre-sales chat for logged-in users on the Jetpack Cloud pricing page.

Additional context: We implemented a Zendesk pre-sales chat interface ( #70590 ) that would only display for logged-out users, however now we want to increase the chat volume by enabling the chat interface to logged-in users also.

Implementation notes:

Enabled feature-flag: jetpack/zendesk-chat-for-logged-in-users in production env (in file: jetpack-cloud-production.json).

Related to #71253

Testing Instructions

Just simply review the code. Verify that in the file config/jetpack-cloud-production.json the feature property jetpack/zendesk-chat-for-logged-in-users is set to true.

I don't think there is any other"manual" way to test this PR, other than to just manually inspect the code. And then once deployed, we can then test that the chat is showing for logged-in users. 🤷‍♂️

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@elliottprogrammer elliottprogrammer added Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) [Feature] Pricing Feedback related to the pricing structure of WordPress.com's plans and services. labels Dec 19, 2022
@elliottprogrammer elliottprogrammer self-assigned this Dec 19, 2022
@elliottprogrammer elliottprogrammer requested a review from a team December 19, 2022 21:12
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 19, 2022
Copy link
Contributor

@rcanepa rcanepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I verified there is no typo in the flag name.

@elliottprogrammer elliottprogrammer merged commit 4ac4170 into trunk Dec 20, 2022
@elliottprogrammer elliottprogrammer deleted the update/enable-presales-chat-logged-in-production branch December 20, 2022 14:01
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 20, 2022
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Pricing Feedback related to the pricing structure of WordPress.com's plans and services. Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants