Jetpack pricing page: Fix lightbox checkout button tracks event

[elliottprogrammer]

Proposed Changes

On the pricing page, in the lightbox, there's a "Proceed to checkout" button which had a misspelled tracks event.

The event before (mispelled):
calyspo_product_lightbox_checkout_click

The event after (fixed):
calypso_product_lightbox_checkout_click

Since the tracking name prefix (calyspo_) was misspelled, this causes the event to be rejected and not work at all.

Testing Instructions

I would say that just a quick code inspection should be enough to test this PR.

Otherwise, if you really wanted to you could:

• Checkout this PR and spin up calypso green (yarn start-jetpack-cloud)
• Go to http://jetpack.cloud.localhost:3000/pricing/
• Open your browser console and enter, localStorage.setItem( "debug", "calypso:analytics" );
• Reload the page, view your console to confirm that you are now receiving Tracks event information.
• On any product, click the "More about {product_name}" link. Lightbox will open.
• Clear out your console (cmd + k)
• Click the "Proceed to checkout" button.
• Verify in the console that you see the calypso_product_lightbox_checkout_click event fires.
• For reference, if needed: Detailed steps on How to See Calypso Tracks Events Fire in Real Time: PCYsg-cae-p2

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to # p1670949293983369/1670944038.246039-slack-C03RCHNVC0H

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-6cab4db49c51ee667568726d14aef1a9607c19d2

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-6cab4db49c51ee667568726d14aef1a9607c19d2&env=jetpack

[vikneshwar]

Tested it, and the event is fired correctly with the mentioned string on checkout from lightbox. LGTM.

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.