Pricing page rework | Remove Feature Flag and Clean up unused code

[manzoorwanijk]

Since we have reached a point of stability for the Pricing Page Rework v1 project. It's the time to revisit and clean up the code and remove the feature flag and its usage.

Proposed Changes

• Remove feature flag usage from the code
• Remove feature flag from config JSON files
• Remove unused code from old pricing page

Testing Instructions

• Do any one of these
  • Click on Jetpack Cloud live link below and wait for the redirect to complete, then goto /pricing
  • or boot up this PR
    • Run git fetch && git checkout pricing-page-rework/clean-up
    • Run yarn start-jetpack-cloud
    • Goto http://jetpack.cloud.localhost:3000/pricing
• Confirm that everything is the same as before
• Confirm the same for Calypso Blue - /plans/:site

Pre-merge Checklist

• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Completes 1202858161751496-as-1202835600809438/f

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1202835600809438

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-52328

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-52328&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~29 bytes removed 📉 [gzipped])

name           parsed_size           gzip_size
entry-stepper        -63 B  (-0.0%)      -29 B  (-0.0%)
entry-main           -63 B  (-0.0%)      -27 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~2959 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
jetpack-cloud-pricing     -11700 B  (-2.2%)    -2918 B  (-1.9%)
plans                     -11660 B  (-1.2%)    -2914 B  (-1.1%)
jetpack-connect           -11543 B  (-1.1%)    -2873 B  (-1.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~26 bytes removed 📉 [gzipped])

name                                           parsed_size           gzip_size
async-load-calypso-blocks-inline-help-popover        -63 B  (-0.0%)      -26 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[monsieur-z]

Everything looks good so far, @manzoorwanijk. I haven't approved it yet since it's still a draft.

[manzoorwanijk]

Everything looks good so far, @manzoorwanijk. I haven't approved it yet since it's still a draft.

Thank you @monsieur-z. I converted it to draft because we want to wait for it for sometime.
Slack conversation: p1665991141552419-slack-C03RCHNVC0H

[matticbot]

This PR modifies the release build for odyssey-stats

To test your changes on WordPress.com, run install-plugin.sh odyssey-stats pricing-page-rework/clean-up on your sandbox.

To deploy your changes after merging, see the documentation: PejTkB-3N-p2

[tyxla]

More follow-up cleanup opportunities are here: #72074.