Framework: return storedVariation if we have one #6904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rralian
added
Framework
[Status] Needs Review
This was referenced Jul 19, 2016
|
Tested and don't see anything out of whack with my default variation. I don't see any other tests that affect the plans page so I can't say if they are affected. |
rralian
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
Looks good to me as well |
|
Great idea - looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to propose that we honor any stored variation if/when we have one for tests that have not yet started. This makes it much easier to test the different variations by using the bug badge abtest helper to manually set variations.
So now for a test that has not yet started, we will return any value currently stored in localStorage first, and if we don't have one, we will return the default variation.
Testing
Make sure this doesn't destroy all things. Maybe try a known test and make sure it still works as expected. But mostly think through the change to see if you can think of any reason we wouldn't want to do this.
/cc @retrofox @apeatling @dmsnell
Test live: https://calypso.live/?branch=update/abtest-allow-savedvariation-preview