LocalizedMoment: refactor tests to @testing-library/react
#68571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
tyxla
approved these changes
Oct 4, 2022
| <MomentProvider store={ store }> | ||
| <LocalizedLabel date="2018-11-01" /> | ||
| </MomentProvider> | ||
| ); | ||
|
|
||
| expect( wrapper.text() ).toEqual( enLabel ); | ||
| expect( container.firstChild ).toHaveTextContent( enLabel ); |
There was a problem hiding this comment.
We could use screen queries here if we want:
Suggested change
| expect( container.firstChild ).toHaveTextContent( enLabel ); | |
| expect( screen.getByText( enLabel ) ).toBeVisible(); |
This is as recommended by the Kent C. Dodds here and is applicable for the rest of the PR.
github-actions
bot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
LocalizedMoment: refactor tests to@testing-library/reactTesting Instructions
Related to #63409