Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Up: Plans width for paid plans only #5929

Closed
wants to merge 1 commit into from

Conversation

rodrigoi
Copy link
Contributor

@rodrigoi rodrigoi commented Jun 9, 2016

Fixing width of plans and plans compare on the signup flow when showing only paid plans

plans
compare

cc: @apeatling @roundhill

Test live: https://calypso.live/?branch=fix/signup-plans-step-white-space

@rodrigoi rodrigoi added [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Pri] Normal Schedule for the next available opportuinity. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. NUX labels Jun 9, 2016
@apeatling
Copy link
Member

The main thing I'm noticing here is that the space at the bottom of the two boxes (marked in red) doesn't match the top. There seems to be a lot of vertical space added for no reason. Can we match the top and bottom padding here?

screen shot 2016-06-09 at 1 58 12 pm

@rodrigoi
Copy link
Contributor Author

Closed by Plans Redesign on #7054

@rodrigoi rodrigoi closed this Jul 29, 2016
@rodrigoi rodrigoi deleted the fix/signup-plans-step-white-space branch July 29, 2016 20:02
@rodrigoi rodrigoi removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. NUX [Pri] Normal Schedule for the next available opportuinity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants