-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State: Selector to get current route path and query #55313
base: add/state-route-types
Are you sure you want to change the base?
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-17668 |
3c39085
to
ef5c7c1
Compare
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~31 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~45 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~130 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
ef5c7c1
to
08e7f24
Compare
2745aab
to
9faa750
Compare
08e7f24
to
ebbd740
Compare
Changes proposed in this Pull Request
Addresses #57109
Adds a new selector to get the current route path & query as a string e.g.
test/url?foo=bar
Testing instructions
Fixes #57109