Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor client/me to use import/order #55190

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Conversation

scinos
Copy link
Contributor

@scinos scinos commented Aug 5, 2021

Background

See #54448

Changes proposed in this Pull Request

Migrate client/me to use import/order

Testing instructions

N/A

Note: there are quite a few eslint failures but none of them should be related to the import/order rule

@scinos scinos requested a review from a team as a code owner August 5, 2021 09:49
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 5, 2021
@scinos scinos mentioned this pull request Aug 5, 2021
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

@scinos scinos requested review from flootr and a team August 5, 2021 09:51
@scinos scinos self-assigned this Aug 5, 2021
@matticbot
Copy link
Contributor

matticbot commented Aug 5, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~21 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
purchases                   -102 B  (-0.0%)       +9 B  (+0.0%)
security                     -45 B  (-0.0%)      +25 B  (+0.0%)
site-purchases               -24 B  (-0.0%)      -62 B  (-0.0%)
help                         +21 B  (+0.0%)      -23 B  (-0.0%)
me                           +18 B  (+0.0%)      -12 B  (-0.0%)
concierge                    -17 B  (-0.0%)      +24 B  (+0.0%)
account                      +17 B  (+0.0%)      -16 B  (-0.0%)
privacy                      +14 B  (+0.0%)      -16 B  (-0.0%)
notification-settings        -12 B  (-0.0%)       -3 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@scinos scinos force-pushed the chore/import-order/client-me branch from 561c731 to b2f6870 Compare August 24, 2021 04:52
@scinos scinos force-pushed the chore/import-order/client-me branch from b2f6870 to 3f9f701 Compare August 24, 2021 08:03
Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsnajdr jsnajdr merged commit 5dd8b22 into trunk Aug 24, 2021
@jsnajdr jsnajdr deleted the chore/import-order/client-me branch August 24, 2021 11:46
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants