Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show pointer cursor for radio and toggles #49998

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

sarayourfriend
Copy link
Contributor

Changes proposed in this Pull Request

Testing instructions

  • Open a page with a toggle on it (like /marketing/traffic/:site) and verify that when hovering over the toggle you see the pointer cursor
  • Open the /devdocs/wordpress-components-gallery and scroll to the Radio input and verify that when hovering over the radio choices you see the pointer cursor.

@sarayourfriend sarayourfriend self-assigned this Feb 11, 2021
@matticbot
Copy link
Contributor

@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 11, 2021
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@griffbrad griffbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Agreed that it ultimately makes sense to address this upstream, though.

@sarayourfriend sarayourfriend merged commit ef9f8ac into trunk Feb 11, 2021
@sarayourfriend sarayourfriend deleted the fix/toggle-pointer branch February 11, 2021 17:15
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle component lost pointer
3 participants