-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move out store setup from extension/woocommerce to my-sites section #49879
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~267 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~1528 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~39 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @ilyasfoo !!
It tested well and LGTM 👍 🚢
@ilyasfoo @moon0326 @becdetat @adrianduffell When a new route like this is added in Calypso, we will need to make a Systems Request to have that route added to those that get handled by Calypso. Otherwise, in production, it will result in a 404. And in this case, we probably shouldn't use |
@mattsherman Oh, that's great to know, thanks! I agree with the new URL
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5529920 Thank you @ilyasfoo for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This PR moves the setup of WooCommerce for Atomic sites that do not yet have the WooCommerce plugin out
extensions/woocommerce
to a standalone page in located under my-sites.The new section can be accessed via
https://wordpress.com/woocommerce/{site}
. In order to support Nav Unification, the actual link to the new woocommerce section from sidebar should be addressed inwpcomsh
repository.Fixes #49424.
Testing instructions
home
withwoocommerce
.calypso_woocommerce_dashboard_action_click
should be called with{ action: 'initial-setup' }
when setup is run.Demo