Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 👷🏼‍♀️ Welcome Tour Animations #47662

Draft
wants to merge 41 commits into
base: trunk
Choose a base branch
from

Conversation

autumnfjeld
Copy link
Contributor

@autumnfjeld autumnfjeld commented Nov 23, 2020

Tech Spike for animations in the Editor Welcome Tour. This is a branch off of #47779

What's going on here?

Looking at feasibility of adding "highlight" animations to the UI during Welcome Tour as shown in this design mockup--the pulses around the inserter button:
pulse

Changes proposed in this Pull Request

My first pass approach:

  1. search for the element by class name,
  2. compute x, y width, hight
  3. position animation in correct spot
  4. then activate animation

A prod implementation would need significant robustness checks, defensive code, and graceful degradation. I wanted to give it a go, but fully aware it might be too fragile (e.g. dependent on class names and such).

Current state of spike:

welcom-tour-animation-spike

Testing instructions

Fixes #

@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D53150-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@autumnfjeld autumnfjeld changed the base branch from try/editor-welcome-portal to add/editor-welcome-tour November 27, 2020 07:41
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Collaborator

@wp-desktop wp-desktop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WordPress Desktop CI Failure for job "wp-desktop-mac".

@autumnfjeld please inspect this job's build steps for breaking changes at this link. For temporal failures, you may try to "Rerun Workflow from Failed".

Please also ensure this branch is rebased off latest Calypso.

@autumnfjeld autumnfjeld force-pushed the add/editor-welcome-tour branch 3 times, most recently from 1370735 to 72f0535 Compare December 15, 2020 00:49
Base automatically changed from add/editor-welcome-tour to trunk December 15, 2020 01:41
@github-actions
Copy link

github-actions bot commented May 5, 2021

This PR has been marked as stale due to lack of activity within the last 30 days.

@razvanpapadopol razvanpapadopol added Spike Editor Welcome Project that is part of bigger scope to help new user's onboard to the WordPress Editor Welcome Tour [Status] In Progress labels Sep 2, 2021
@razvanpapadopol razvanpapadopol requested a review from a team September 2, 2021 13:42
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editor Welcome Project that is part of bigger scope to help new user's onboard to the WordPress Editor Spike [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Stale Welcome Tour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants