-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 👷🏼♀️ Welcome Tour Animations #47662
base: trunk
Are you sure you want to change the base?
Conversation
…oad new WelcomeTour
…oad new WelcomeTour
…elcomeCardTour. todo: pagination of cards
… card content with working next button to advance to next card
…nto TourCard for pagination
…uctional content by getElementsByClassName then positioning animation on the node
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D53150-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
…oad new WelcomeTour
…oad new WelcomeTour
…elcomeCardTour. todo: pagination of cards
… card content with working next button to advance to next card
…nto TourCard for pagination
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WordPress Desktop CI Failure for job "wp-desktop-mac".
@autumnfjeld please inspect this job's build steps for breaking changes at this link. For temporal failures, you may try to "Rerun Workflow from Failed".
Please also ensure this branch is rebased off latest Calypso.
1370735
to
72f0535
Compare
This PR has been marked as stale due to lack of activity within the last 30 days. |
Tech Spike for animations in the Editor Welcome Tour. This is a branch off of #47779
What's going on here?
Looking at feasibility of adding "highlight" animations to the UI during Welcome Tour as shown in this design mockup--the pulses around the inserter button:
Changes proposed in this Pull Request
My first pass approach:
A prod implementation would need significant robustness checks, defensive code, and graceful degradation. I wanted to give it a go, but fully aware it might be too fragile (e.g. dependent on class names and such).
Current state of spike:
Testing instructions
Fixes #