Jetpack Search: enable purchases via "...search/yearly" routes. #43865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are defined adding /yearly to the url. We take those as default and skip including yearly in product type slug. So e.g. jetpack_search is the yearly version, while jetpack_search_monthly, its monthly version.
AnnaMag
added
[Type] Enhancement
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~7 bytes removed 📉 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
It would not work with the new route, which is shorter.
AnnaMag
force-pushed
the
add/process-yearly-search
branch
2 times, most recently
from
f2cb215 to
2c7a3d4
Compare
Atm it is adding an empty product to the Cart and redirecting to /plans.
AnnaMag
force-pushed
the
add/process-yearly-search
branch
from
2c7a3d4 to
cc26a25
Compare
gibrown
approved these changes
Jul 2, 2020
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
/jetpack/connect/jetpack_search/yearlyand/jetpack/connect/wpcom_search/yearlyroutes.At the moment inputting urls is disabled at those screens. We use
/jetpack/connect/jetpack_searchfor yearly product type, but since /yearly had been defined as a route, we should keep it functional.Also, here we adapt product type definition such that it is independent of the actual route.
Second fix is processing purchases for Jetpack sites- we correct the condition that moderated WP.com vs. JP site type of product at checkout. It was adding an empty product and as such, redirecting to /plans.
Testing instructions
/jetpack/connect/(jetpack|wpcom)_search/yearlyand verify the purchase process.