Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Connect: add a separate notice for WP.com sites purchasing Search #41257

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Jetpack Connect: add a separate notice for WP.com sites purchasing Search #41257

merged 2 commits into from
Apr 23, 2020

Conversation

AnnaMag
Copy link
Contributor

@AnnaMag AnnaMag commented Apr 19, 2020

Atm, Search is a Jetpack product, but it will become available for WP.com sites in the future.

Changes proposed in this Pull Request

  • Here, we add a notice when users arrive at the connection step following Search purchase flow and input their WP.com site address.

Testing instructions

  • start at the url input form of the JPC flow: /jetpack/connect/jetpack_search (try with parameters e.g. being redirected from the LP ?cta_id=landing-page-search-primary-cta&cta_from=upgrade_search
  • input a WP.com site
  • verify that the notice appears:

wpcomsearch

@AnnaMag AnnaMag added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Copy Review Add this when you'd like to get a review / feedback from the Editorial team on your PR [Feature] Search Jetpack Search - A feature to speed up and improve the look of Search on your site. labels Apr 19, 2020
@AnnaMag AnnaMag requested review from keoshi, gibrown and jsnmoon April 19, 2020 16:24
@AnnaMag AnnaMag self-assigned this Apr 19, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/jpc-for-wpcom

@matticbot
Copy link
Contributor

matticbot commented Apr 19, 2020 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~70 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect       +235 B  (+0.0%)      +70 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@AnnaMag AnnaMag force-pushed the add/jpc-for-wpcom branch 2 times, most recently from 61ea13d to 5322a67 Compare April 19, 2020 16:27
@kristastevens
Copy link

Hello! Here are some small copy suggestions to avoid a little repetition in the headline of the notice and the body copy.

I suggest changing the headline to read:

We're setting up Jetpack

Which tees up the next line (minor mods here:)

We're installing the Jetpack plugin so that WordPress.com can communicate with your self-hosted WordPress site.

I'd suggest one minor change to the dismissible notice:

Good news! Jetpack's Search feature is coming soon to WordPress.com sites.

@AnnaMag AnnaMag removed the [Status] Needs Copy Review Add this when you'd like to get a review / feedback from the Editorial team on your PR label Apr 21, 2020
@AnnaMag AnnaMag mentioned this pull request Apr 21, 2020
Closed
jsnmoon
jsnmoon approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@jsnmoon jsnmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described.

@AnnaMag
Jetpack Connect: add separate notice for WP.com sites purchasing Search
6dbced1 
Atm, Search is a Jetpack product, but it will become available for WP.com sites
in the future. Here we add a notice when users arrive at the connection step
following Search purchase flow and input their WP.com site address.
@AnnaMag
Copy link
Contributor Author

AnnaMag commented Apr 23, 2020 •
edited
Loading

Thank you! Applied changes to the dismissible notice with a modification of removing feature mention, since JPS is a product of its own. The remaining ones change JPC itself, which is beyond the scope of this PR.

@AnnaMag AnnaMag force-pushed the add/jpc-for-wpcom branch from 5322a67 to dbfdc68 Compare April 23, 2020 18:11
@AnnaMag AnnaMag merged commit 4736073 into master Apr 23, 2020
@AnnaMag AnnaMag deleted the add/jpc-for-wpcom branch April 23, 2020 20:03
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 23, 2020
@a8ci18n
Copy link

a8ci18n commented May 22, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3361892

Thank you @AnnaMag for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented May 26, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnmoon jsnmoon jsnmoon approved these changes

@keoshi keoshi Awaiting requested review from keoshi

@gibrown gibrown Awaiting requested review from gibrown

Assignees

@AnnaMag AnnaMag

Labels
[Feature] Search Jetpack Search - A feature to speed up and improve the look of Search on your site. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AnnaMag @matticbot @kristastevens @a8ci18n @jsnmoon