Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site migration: fix typo in error for WordPress.com hosted source sites #40117

Merged
merged 1 commit into from
Mar 14, 2020

Conversation

andfinally
Copy link
Contributor

Changes proposed in this Pull Request

  • Fixes a small typo in the error message This is site is.

Testing instructions

  • Apply the PR or use Calypso.live.
  • Go to import/[ site ], select WordPress and enter the URL of a site that's already hosted on WordPress.com.
  • You should see the corrected error message.

image

@andfinally andfinally added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. WP Migration Use "[Feature] Site Migration" ___ Old lable related to WP Migration Project (pbkcP4-8-p2) labels Mar 13, 2020
@andfinally andfinally self-assigned this Mar 13, 2020
@matticbot
Copy link
Contributor

@@ -75,7 +75,7 @@ class StepSourceSelect extends Component {
case 'wordpress':
if ( result.site_meta.wpcom_site ) {
return this.setState( {
error: translate( 'This is site is already hosted on WordPress.com' ),
error: translate( 'This site is already hosted on WordPress.com' ),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 This change will be queued for retranslation. We'll use the existing translations in the meantime.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@mattsherman mattsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lancewillett lancewillett merged commit 8b5e4f2 into master Mar 14, 2020
@lancewillett lancewillett deleted the fix/migration-already-hosted-typo branch March 14, 2020 17:46
@lancewillett lancewillett removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WP Migration Use "[Feature] Site Migration" ___ Old lable related to WP Migration Project (pbkcP4-8-p2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants