Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade wp-prettier to 1.19.1 #37568

Merged
merged 3 commits into from
Nov 13, 2019
Merged

Upgrade wp-prettier to 1.19.1 #37568

merged 3 commits into from
Nov 13, 2019

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Nov 13, 2019

What's new:

  • formatting of function calls that are or look like function composition use a different heuristic now. In Calypso practice, it affect formatting of connect calls that are now very often formatted as one-liners instead of breaking into multiple lines
  • fixed a paren-spacing bug where automatically inserted raw JSX whitespace has correct spacing: { ' ' } instead of {' '} (discovered by Gutenberg reviewers)
  • support for optional chaining and null coalescing 🎉

@jsnajdr jsnajdr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Build labels Nov 13, 2019
@jsnajdr jsnajdr requested review from blowery, ockham, sirreal and a team November 13, 2019 17:57
@jsnajdr jsnajdr requested review from a team as code owners November 13, 2019 17:57
@jsnajdr jsnajdr self-assigned this Nov 13, 2019
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/prettier-1.19.1

@jsnajdr jsnajdr mentioned this pull request Nov 13, 2019
Merged
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

sirreal
sirreal approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is upgrading prettier and running reformat-files: yes, please, yes!

Let's wait for e2e just in case. Lint errors should be ignorable 👍

@jsnajdr jsnajdr merged commit 1835f94 into master Nov 13, 2019
@jsnajdr jsnajdr deleted the update/prettier-1.19.1 branch November 13, 2019 18:27
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirreal sirreal sirreal approved these changes

@blowery blowery Awaiting requested review from blowery

@ockham ockham Awaiting requested review from ockham

Assignees

@jsnajdr jsnajdr

Labels
Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsnajdr @matticbot @sirreal