Skip to content

Customer Home: rename navigation menu item Home to My Home #35901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2019
Merged

Customer Home: rename navigation menu item Home to My Home #35901

merged 1 commit into from
Aug 30, 2019

Conversation

eliorivero
Copy link
Contributor

@eliorivero eliorivero commented Aug 30, 2019 •
edited
Loading

Changes proposed in this Pull Request

  • rename Home to My Home

Screen Shot 2019-08-30 at 09 11 47

Testing instructions

  • ensure the navigation item says My Home not Home

Fixes #35900

@eliorivero eliorivero added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] My Home The main dashboard for managing a WordPress.com site. labels Aug 30, 2019
@eliorivero eliorivero requested a review from pablinos August 30, 2019 12:01
@eliorivero eliorivero self-assigned this Aug 30, 2019
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/home-my-home

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@eliorivero eliorivero force-pushed the update/home-my-home branch 2 times, most recently from 8bdcaa0 to 20417e3 Compare August 30, 2019 13:58
@eliorivero eliorivero force-pushed the update/home-my-home branch from 20417e3 to 5222267 Compare August 30, 2019 14:07
@eliorivero eliorivero merged commit a8e5e6d into master Aug 30, 2019
@eliorivero eliorivero deleted the update/home-my-home branch August 30, 2019 14:36
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablinos pablinos Awaiting requested review from pablinos

Assignees

@eliorivero eliorivero

Labels
[Feature] My Home The main dashboard for managing a WordPress.com site. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customer Home: Rename sidenav Home --> My home
2 participants
@eliorivero @matticbot