Imports: Improve import progress text to be more informative #35808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andfinally
added
[Status] Needs Review
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~11 bytes added 📈 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
andfinally
changed the title
jonathansadowski
suggested changes
Aug 27, 2019
| @@ -179,8 +179,8 @@ class ImportingPane extends React.PureComponent { | |||
| } | |||
|
|
|||
| return this.props.translate( | |||
| 'Waiting on %(numResources)s resource to import', | |||
| 'Waiting on %(numResources)s resources to import', | |||
| '%(numResources)s post, page or media file left to import', | |||
There was a problem hiding this comment.
Suggested change
| '%(numResources)s post, page or media file left to import', | |
| '%(numResources)s post, page, or media file left to import', |
| 'Waiting on %(numResources)s resource to import', | ||
| 'Waiting on %(numResources)s resources to import', | ||
| '%(numResources)s post, page or media file left to import', | ||
| '%(numResources)s posts, pages and media files left to import', |
There was a problem hiding this comment.
Suggested change
| '%(numResources)s posts, pages and media files left to import', | |
| '%(numResources)s posts, pages, and media files left to import', |
andfinally
force-pushed
the
fix/import-progress-resource-wording
branch
from
30e652b to
2a27eac
Compare
jonathansadowski
approved these changes
Aug 27, 2019
andfinally
added
[Status] Needs Review
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text
Waiting on xxx resources to importbeneath the import progress bar is currently not very helpful to ordinary folks: it won't be clear to them what "resources" means.I'm proposing this change as an interim measure which may be replaced if we implement better progress reporting for imports. Personally I'm not sure about the wordiness this adds to the UI. I'd say there's even a case for making it simpler with
xxx things left to import.Changes proposed in this Pull Request
Testing instructions
calypso.live./import/[ site ], choose the WordPress importer and upload a test import file. Go past the author mapping stage and wait for the progress bar to appear.xxx posts, pages and media files left to import.