Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import in Signup: Make isValid property in user URL submit Track lowercase #35661

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

andfinally
Copy link
Contributor

@andfinally andfinally commented Aug 21, 2019

Changes proposed in this Pull Request

  • Properties in Track calls must be lowercase. Properties with uppercase letters cause the console error
Tracks: Event `calypso_signup_import_url_submit` will be rejected because property name `isValid` does not match /^[a-z_][a-z0-9_]*$/. Please use a compliant property name.
  • Change the isValid property to isvalid.

Testing instructions

  • Check out the branch, run Calypso and go to a signup flow which uses the import-url-onboarding step, for example http://calypso.localhost:3000/start/import-onboarding/ (Click on the bug icon and set the A/B test value showImportFlowInSiteTypeStep to show to see the "Already have a website?" link.)
  • Open the network tab of dev tools and filter by pixel.wp.com.
  • Enter an invalid URL in the input and - without blurring the input - click on the "Continue" button.
  • The page should make a request to the tracking pixel http://pixel.wp.com/t.gif. As well as the flow name and the URL you entered, the request params should include a correct isvalid property.
  • Enter a valid URL in the input and click "Continue" again.
  • The page should make another request to the tracking pixel, passing similar params.

Related #35606

@andfinally andfinally requested a review from a team as a code owner August 21, 2019 16:30
@matticbot
Copy link
Contributor

@andfinally andfinally self-assigned this Aug 21, 2019
@andfinally andfinally requested review from a team and removed request for a team August 21, 2019 16:32
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@mattsherman mattsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved -- tested and observed correct property in Tracks request.

@andfinally andfinally merged commit 6aa2705 into master Aug 21, 2019
@andfinally andfinally deleted the fix/import-signup-flow-url-track branch August 21, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants